Storybook #37
Merged
Storybook #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msluther
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Much nicer.
You could also consider using the @exemplar/storybook-react preset to help drive the examples.
Also would be good to work in storybook's knobs at some point on some of the stories.
|
@msluther yea that would be good to add in, did you want me to implement that before we merge in or are we good to go with this PR? |
|
@Shaun2D2 I definitely wouldn't block this PR on that. Its good on its own, but a follow up PR would be nice, or at least an issue to track it perhaps. |
|
@Shaun2D2 Typically 2 ✅ approvals and we merge to master. Lets poke @chrishinrichs and see if there are any other comments. |
SivanMehta
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.