Skip to content

Conversation

@pboyd04
Copy link

@pboyd04 pboyd04 commented Sep 30, 2024

This does a few things to tests:

  1. Ensure those with go routines actually complete as expected and not just rely on luck.
  2. Increase the number of benchmarks
  3. Actually compare the encoding result of the data to ensure it is accurate (the tests were just using go logic to decode to verify and if you make changes to the encoder that may still pass even though the actual output was bad. This resolves that.)
  4. Adds a Reset method to Encoder. Right now this is just used for making the Benchmarks more accurate. In the future this will be used to increase the throughput of the encoder.

@pboyd04
Copy link
Author

pboyd04 commented Nov 18, 2025

Any updates as to when this might get merged? I would like to start moving in optimizations so I don't have to keep maintaining patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant