Bump golangci-lint to v2, fix some issues found #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer needed since commit 33c352a changed go to 1.20 in go.mod. Signed-off-by: Kir Kolyshkin <[email protected]>
Those are no longer needed as the package requires Go >= 1.20 since commit 33c352a. Generated by go fix ./... Signed-off-by: Kir Kolyshkin <[email protected]>
Like this: > object_test.go:71:7: ST1006: receiver name should not be an underscore, omit the name if it is unused (staticcheck) Signed-off-by: Kir Kolyshkin <[email protected]>
As recommended by staticcheck linter, e.g. > conn.go:448:3: QF1003: could use tagged switch on member (staticcheck) Signed-off-by: Kir Kolyshkin <[email protected]>
As recommended by the staticcheck linter: > variant_parser.go:295:2: QF1002: could use tagged switch on sig.str (staticcheck) Signed-off-by: Kir Kolyshkin <[email protected]>
As recommended by the staticcheck linter, e.g. > auth.go:60:14: QF1008: could remove embedded field "transport" from selector (staticcheck)
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. I have refrained from adding extra linters or making some massive modifications.