Allow more than 32 containers / struct fields in a signature #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5942541. Pointer semantics on the caller are actually incorrect here: the returned depthCounter is passed on to a deeper validation function, but that shouldn't modify the original depthCounter from the caller. With pointer semantics, we don't count e.g. the depth of array nesting, but just how many arrays are present in the signature. For structs this is especially bad since EnterStruct is called for each struct field, so this unintentionally limited the number of struct fields that could be present in a signature to 32. Fixes #425.
guelfey
force-pushed
the
fix/struct_member_32
branch
from
a383a19 to
81b5551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5942541.
Pointer semantics on the caller are actually incorrect here: the
returned depthCounter is passed on to a deeper validation function, but
that shouldn't modify the original depthCounter from the caller. With
pointer semantics, we don't count e.g. the depth of array nesting, but
just how many arrays are present in the signature. For structs this is
especially bad since EnterStruct is called for each struct field, so
this unintentionally limited the number of struct fields that could be
present in a signature to 32.
Fixes #425.