Skip to content

Conversation

@dims
Copy link
Contributor

@dims dims commented Dec 20, 2025

in d3fc3b5 the usage of user.Current() was dropped, but the corresponding import was left "os/user"

found in kubernetes CI jobs:

confirmed fix by running https://github.com/dims/typecheck

❯ typecheck
type-checking windows/arm64
type-checking darwin/arm64
ERROR(windows/arm64): /Users/dsrinivas/go/src/github.com/godbus/dbus/auth_sha1_windows.go:10:2: "os/user" imported and not used
type-checking windows/386
type-checking linux/amd64
ERROR(windows/386): /Users/dsrinivas/go/src/github.com/godbus/dbus/auth_sha1_windows.go:10:2: "os/user" imported and not used
type-checking windows/amd64
ERROR(windows/amd64): /Users/dsrinivas/go/src/github.com/godbus/dbus/auth_sha1_windows.go:10:2: "os/user" imported and not used
type-checking linux/arm
type-checking linux/386
type-checking linux/ppc64le
type-checking linux/arm64
type-checking linux/s390x
type-checking darwin/amd64

cc @kolyshkin

@dims
Copy link
Contributor Author

dims commented Dec 20, 2025

xref: kubernetes/kubernetes#135864

@kolyshkin
Copy link
Contributor

My bad; the fix LGTM

@kolyshkin
Copy link
Contributor

@guelfey PTAL; this is a followup fix to #422 which introduces a Windows only regression in v5.2.1 (missed as we don't have a CI job to compile code on Windows).

@guelfey guelfey merged commit a8ac15b into godbus:master Dec 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants