Remove gensym, fix Wasm class registration
#1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
bug
c: wasm
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1092 |
Changes: * Remove `gensym`, no longer in use * Remove `owning-ref`, already caught by cargo-deny due to RustSec anyway * Add `rand`, it has a ridiculous dep tree for what it offers - for low-level randomness, we can use Godot or libc::rand().
Bromeon
force-pushed
the
bugfix/wasm-registration
branch
from
2ba8c38 to
c5d76d9
Compare
PgBiel
approved these changes
Mar 23, 2025
|
Thank you for testing! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
gensymcrate and replaces it with our own proc-macro, thus further cutting down on dependencies.Fixes a regression related to auto-registering classes in Wasm, introduced in #1069 (comment).
Also updates feature docs. At the same time, I updated the demo-projects repo to contain an export preset for Web, and a correct
.cargo/config.tomlfile. I tested Web export locally with Godot 4.4, works for me with thebuild-wasm.shscript.