Global<T> to store global variables ergonomically
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave in 2 places: one actually needs Option for late-init, the other needs try_lock(). Also use ClassName by value whenever possible, since it's Copy.
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-547 |
Bromeon
force-pushed
the
feature/global-cell
branch
from
61d43b7 to
f6dc092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
once_cell::Lazy, this type allows lazy initialization instaticvariables, withoutOptionor other workarounds. The implementation was initially very simple (just 100 LoC), but got a bit more involved oncetry_lock()was added. An older commit contains the simpler implementation. Depending on needs, we might also considerRwLockinstead ofMutexinternally, but I think it's not necessary right now, and it would add quite a bit of further complexity in both implementation and usage (e.g. for caches).I replaced two occurrences of
Mutex<Option<T>>in gdext withGlobal<T>and added a new one.Global<T>is currently not part of the public API, but we may consider exposing it if there is demand.At some point, we should also consider what to do with the
static mutin godot-ffi that gives access to the entireBINDING. We need to see if concurrent access is needed. And if yes, how to provide it without compromising performance for every single Godot API call.