Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get and set as virtual methods #567

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Add get and set as virtual methods #567

merged 1 commit into from
Jan 21, 2024

Conversation

lilizoey
Copy link
Member

No description provided.

@lilizoey lilizoey added feature Adds functionality to the library c: register Register classes, functions and other symbols to GDScript labels Jan 15, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-567

@Bromeon
Copy link
Member

Bromeon commented Jan 15, 2024

Thanks a lot! Is it OK if this waits until after my announced refactoring? I hope it doesn't cause too many conflicts 😕 but the other way around would be a nightmare...

@lilizoey
Copy link
Member Author

Thanks a lot! Is it OK if this waits until after my announced refactoring? I hope it doesn't cause too many conflicts 😕 but the other way around would be a nightmare...

Ye no worries

Bromeon
Bromeon reviewed Jan 21, 2024
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Interestingly, #573 did not break this 👀

I'll merge this due to further refactorings causing lots of divergence, but I might change a few things in follow-up PRs.

@Bromeon Bromeon added this pull request to the merge queue Jan 21, 2024
Merged via the queue into godot-rust:master with commit 60a42ae Jan 21, 2024
16 checks passed
@Bromeon Bromeon mentioned this pull request Feb 28, 2024
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon left review comments

Assignees
No one assigned
Labels
c: register Register classes, functions and other symbols to GDScript feature Adds functionality to the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilizoey @GodotRust @Bromeon