Refactor II: split code generators into specialized modules #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator files Breaks up the multi-kLoC files and separates them by topic. Improves searchability, encapsulation and overall code organization. Several symbols have also been moved where they fit better (e.g. domain models).
Also modifies an invocation to use is_class_deleted() instead of is_class_excluded() -- changes semantics.
Bromeon
added
the
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #573, this reorganizes the entire file structure of the
godot-codegencrate.Instead of two monolithic files
class_generator.rsandcentral_generator.rswhich have grown to a total of 3000 LoC, we have now 16 generator files, each specialized on a certain area of responsibility. This improves code organization, searchability and encapsulation.I also have to shill RustRover's Refactor > Move functionality at this point. It has worked near-perfectly and carried 95% of the changes here. The only things I needed to adjust manually were visibility modifiers in some places (and RR warned me about them). Import statements were nicely rewritten 🚀