Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringName::transient_ord() #586

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Add StringName::transient_ord() #586

merged 5 commits into from
Jan 31, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Jan 30, 2024

StringName ordering was originally blocked by godotengine/godot#76218. Deliberately does not implement Ord and PartialOrd, because the relation is non-lexicographic and unstable across runs. Instead, provide StringName::transient_ord() method for fast ordering without these properties.

Removes deprecated module godot::bind and type GodotString.
Removes some accidentally imported symbols from the prelude.

Improves Projection documentation and adds try_from() methods for its related types ProjectionPlane and ProjectionEye.

@Bromeon Bromeon added feature Adds functionality to the library c: core Core components labels Jan 30, 2024
@Bromeon Bromeon force-pushed the qol/string-name-ord branch 2 times, most recently from e264378 to b1390df Compare January 30, 2024 22:24
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-586

Also document some other traits for builtin types.
@Bromeon Bromeon force-pushed the qol/string-name-ord branch from b1390df to ea48200 Compare January 30, 2024 22:28
@Bromeon Bromeon force-pushed the qol/string-name-ord branch 2 times, most recently from 6276b8f to 906a120 Compare January 31, 2024 20:41
@Bromeon Bromeon force-pushed the qol/string-name-ord branch from 906a120 to bcc1e9b Compare January 31, 2024 21:01
@Bromeon Bromeon enabled auto-merge January 31, 2024 21:05
@Bromeon Bromeon added this pull request to the merge queue Jan 31, 2024
Merged via the queue into master with commit 1d2b7ce Jan 31, 2024
16 checks passed
@Bromeon Bromeon deleted the qol/string-name-ord branch January 31, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: core Core components feature Adds functionality to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants