-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
derive Clone, PartialEq, Debug for native structs #587
derive Clone, PartialEq, Debug for native structs #587
Conversation
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-587 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 🙂
Could you maybe add 3 #[itest]
functions in native_structures_test.rs? One for each trait.
Each test could use a different native structure (but one per test is enough).
Added! Included |
1ac4456
to
e09a3ee
Compare
Last feedback round:
Thanks! 🙂 |
To combine commits to one, a simple approach is:
Make sure you keep the |
0e7c46b
to
9e97aa9
Compare
Thanks! I kept missing steps. |
aa37ce6
to
df302ea
Compare
Goofed, thanks for the patience. |
Thanks a lot for your first PR! 😊 |
Ignore branch name. Closes #404