Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive Clone, PartialEq, Debug for native structs #587

Conversation

vortexofdoom
Copy link
Contributor

Ignore branch name. Closes #404

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-587

@Bromeon Bromeon added feature Adds functionality to the library c: engine Godot classes (nodes, resources, ...) labels Jan 31, 2024
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙂

Could you maybe add 3 #[itest] functions in native_structures_test.rs? One for each trait.

Each test could use a different native structure (but one per test is enough).

@vortexofdoom
Copy link
Contributor Author

Added! Included ObjectId for debug since it was simplest to write out manually, otherwise used existing constructors.

@vortexofdoom vortexofdoom force-pushed the derive-clone-copy-partialeq-native-types branch from 1ac4456 to e09a3ee Compare January 31, 2024 15:54
@Bromeon
Copy link
Member

Bromeon commented Jan 31, 2024

Last feedback round:

  • run rustfmt
  • end comments with full stop (.) when possible
  • combine the 2 commits to a single one (following Contributing.md)

Thanks! 🙂

@Bromeon
Copy link
Member

Bromeon commented Jan 31, 2024

To combine commits to one, a simple approach is:

git reset --soft master
git commit -am "message"
git push --force-with-lease

Make sure you keep the --soft!

@vortexofdoom vortexofdoom force-pushed the derive-clone-copy-partialeq-native-types branch from 0e7c46b to 9e97aa9 Compare January 31, 2024 19:00
@vortexofdoom
Copy link
Contributor Author

Thanks! I kept missing steps.

@vortexofdoom vortexofdoom force-pushed the derive-clone-copy-partialeq-native-types branch from aa37ce6 to df302ea Compare January 31, 2024 19:11
@vortexofdoom
Copy link
Contributor Author

vortexofdoom commented Jan 31, 2024

Goofed, thanks for the patience.

@vortexofdoom vortexofdoom reopened this Jan 31, 2024
@Bromeon Bromeon enabled auto-merge January 31, 2024 20:24
@Bromeon Bromeon added this pull request to the merge queue Jan 31, 2024
Merged via the queue into godot-rust:master with commit b91dd31 Jan 31, 2024
18 checks passed
@Bromeon
Copy link
Member

Bromeon commented Jan 31, 2024

Thanks a lot for your first PR! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: engine Godot classes (nodes, resources, ...) feature Adds functionality to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would it be possible to make AudioFrame: Clone + Copy?
3 participants