Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo files for Godot 4.2.1 #1013

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 29, 2024

All demos were opened with Godot 4.2.1, with the mesh format upgraded for 3D demos.

The 3D antialiasing demo now uses Extra Cull Margin on the last object to prevent it from disappearing too early when the camera rotates (due to its use of shader-based animation).

This is a prerequisite for uploading demos to the asset library, then #868 can be worked on.

All demos were opened with Godot 4.2.1, with the mesh format
upgraded for 3D demos.

The 3D antialiasing demo now uses Extra Cull Margin on the last
object to prevent it from disappearing too early when the camera
rotates (due to its use of shader-based animation).
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but I trust it implicitly, it's a simple noisy bulk update by a highly trusted contributor.

Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loaded most projects and did not encounter any project caused error.

All errors I encounter happen regularly in the stable version so not really a thing caused by this pr or the demo.

@Calinou Calinou merged commit 2a96292 into godotengine:master Feb 1, 2024
1 check passed
@Calinou Calinou deleted the update-for-4.2 branch February 1, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants