Fix arrays with resources not being updated correctly in game when edited in the inspector #111446
+142
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.5
…ited in the inspector
|
Fixed some issues with variable shadowing and the -Wlogical-not-parentheses issue |
|
The GHA Windows Teomplate build was canceled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request fixes #101979
It transforms resources in arrays to resource paths before sending them through the debugger.
At the game instance the resources are then loaded again by using the resource path.
This is how Godot currently handles updating single resources in the inspector.
the typed_builtin, typed_class_name and typed_script have to be sent or else exposed arrays of custom-GDScript-resource-sub-types will not update correctly.
res_indexes_array is there so that the solution also works with arrays of Variant/Object, since those can contain Resources too.
Arrays of Variant/Object also have the same bug with resources not being updated correctly.