Allow drag_preview to be handled by a different viewport than its parent #64949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinusKube
force-pushed
the
drag-preview-viewport-bug
branch
from
f104282 to
0321946
Compare
|
An alternative for this PR is #67531, which handles dragging application-wide in the Window-Manger-Window. |
|
Superseded by #67531. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59622
For the visual scripting node dragging, we need to be able to differentiate between the viewport which will handle the drag preview position, and the viewport which will contain the preview in its tree.
I've done that by adding an optional parameter to the control's
force_dragandset_drag_previewmethods, which defines the control that will be used to determine the preview's parent (the parameter defaults tothisif left null).