Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect drag preview position under transformed CanvasLayer. #98032

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix incorrect drag preview position under transformed CanvasLayer. #98032

merged 1 commit into from
Dec 9, 2024

Conversation

zaevi
Copy link
Contributor

@zaevi zaevi commented Oct 9, 2024

@zaevi zaevi requested a review from a team as a code owner October 9, 2024 19:14
@zaevi zaevi changed the title Fix incorrect drag preview position under transformed CanvasLayer. Fix incorrect drag preview position under transformed CanvasLayer. Oct 9, 2024
@AThousandShips AThousandShips added bug topic:input topic:gui cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 10, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 10, 2024
@Sauermann Sauermann self-requested a review October 17, 2024 22:49
Sauermann
Sauermann approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR rebased on 58a7f9b and it fixes the mentioned bug.
The implementation and codestyle looks correct.

Related to #67186, which would require a complete rewrite of the drag preview.

@Repiteo Repiteo merged commit 09dd5e6 into godotengine:master Dec 9, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 9, 2024

Thanks!

@zaevi zaevi deleted the fix_drag_preview_position branch December 9, 2024 20:46
@Spartan322 Spartan322 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann Sauermann approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:gui topic:input
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Drag preview is affected by CanvasLayer offset
4 participants
@zaevi @Repiteo @Sauermann @AThousandShips