Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR: Fix pose recenter signal to be omitted properly #99159

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

BastiaanOlij
Copy link
Contributor

@BastiaanOlij BastiaanOlij commented Nov 13, 2024

This fixes the pose recenter logic in the OpenXR interface.

To test use: godotengine/godot-demo-projects#1131

Fixes #99157

@BastiaanOlij BastiaanOlij added bug topic:xr cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 13, 2024
@BastiaanOlij BastiaanOlij added this to the 4.4 milestone Nov 13, 2024
@BastiaanOlij BastiaanOlij self-assigned this Nov 13, 2024
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner November 13, 2024 03:21
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the changes but the logic looks good!

@Repiteo Repiteo merged commit 318fe5f into godotengine:master Nov 13, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 13, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:xr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenXR: inconsistent results with pose recenter
3 participants