x/crypto: increasing the default BCrypt cost #326
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at git blame, it appears the DefaultCost for the Bcrypt library has remained unchanged for the past 14 years.
To keep up with modern hardware, I propose upgrading the Bcrypt library's DefaultCost from 10 to 12 to match the PHP 8.4 recent update in 2024.
Please see PHP's RFC for research on this topic, but please keep in mind the benchmarks are specific to PHP: https://wiki.php.net/rfc/bcrypt_cost_2023