net/url: reduce allocs in Encode #75874

jub0bs · 2025-10-13T15:08:20Z

This change adds benchmarks for Encode and reverts what CL 617356 did in
this package. At the moment, using maps.Keys in conjunction with
slices.Sorted indeed causes a bunch of closures to escape to heap.
Moreover, all other things being equal, pre-sizing the slice in which
we collect the keys is beneficial to performance when they are "many" (>8)
keys because it results in fewer allocations than if we don't pre-size the
slice.

Here are some benchmark results:

goos: darwin
goarch: amd64
pkg: net/url
cpu: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
│ old │ new │
│ sec/op │ sec/op vs base │
EncodeQuery/#00-8 2.051n ± 1% 2.343n ± 1% +14.24% (p=0.000 n=20)
EncodeQuery/#1-8 2.337n ± 1% 2.458n ± 4% +5.16% (p=0.000 n=20)
EncodeQuery/oe=utf8&q=puppies-8 489.6n ± 0% 284.5n ± 0% -41.88% (p=0.000 n=20)
EncodeQuery/q=dogs&q=%26&q=7-8 397.2n ± 1% 231.7n ± 1% -41.66% (p=0.000 n=20)
EncodeQuery/a=a1&a=a2&a=a3&b=b1&b=b2&b=b3&c=c1&c=c2&c=c3-8 743.1n ± 0% 519.0n ± 0% -30.16% (p=0.000 n=20)
EncodeQuery/a=a&b=b&c=c&d=d&e=e&f=f&g=g&h=h&i=i-8 1324.0n ± 0% 931.0n ± 0% -29.68% (p=0.000 n=20)
geomean 98.57n 75.38n -23.53%

                                                       │      old      │                 new                  │
                                                       │     B/op      │    B/op     vs base                  │

EncodeQuery/#00-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹
EncodeQuery/#1-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹
EncodeQuery/oe=utf8&q=puppies-8 168.00 ± 0% 56.00 ± 0% -66.67% (p=0.000 n=20)
EncodeQuery/q=dogs&q=%26&q=7-8 112.00 ± 0% 32.00 ± 0% -71.43% (p=0.000 n=20)
EncodeQuery/a=a1&a=a2&a=a3&b=b1&b=b2&b=b3&c=c1&c=c2&c=c3-8 296.0 ± 0% 168.0 ± 0% -43.24% (p=0.000 n=20)
EncodeQuery/a=a&b=b&c=c&d=d&e=e&f=f&g=g&h=h&i=i-8 680.0 ± 0% 264.0 ± 0% -61.18% (p=0.000 n=20)
geomean ² -47.48% ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                                       │      old      │                 new                  │
                                                       │   allocs/op   │ allocs/op   vs base                  │

EncodeQuery/#00-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹
EncodeQuery/#1-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹
EncodeQuery/oe=utf8&q=puppies-8 8.000 ± 0% 3.000 ± 0% -62.50% (p=0.000 n=20)
EncodeQuery/q=dogs&q=%26&q=7-8 7.000 ± 0% 3.000 ± 0% -57.14% (p=0.000 n=20)
EncodeQuery/a=a1&a=a2&a=a3&b=b1&b=b2&b=b3&c=c1&c=c2&c=c3-8 10.000 ± 0% 5.000 ± 0% -50.00% (p=0.000 n=20)
EncodeQuery/a=a&b=b&c=c&d=d&e=e&f=f&g=g&h=h&i=i-8 12.000 ± 0% 5.000 ± 0% -58.33% (p=0.000 n=20)
geomean ² -43.23% ²
¹ all samples are equal
² summaries must be >0 to compute geomean

gopherbot · 2025-10-13T15:13:45Z

This PR (HEAD: 38a1551) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/711280.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-13T15:21:54Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T15:21:55Z

Message from jub0bs:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T15:38:05Z

Message from Jes Cok:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T15:54:04Z

Message from jub0bs:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T17:35:16Z

Message from Sean Liao:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-13T18:35:27Z

This PR (HEAD: 569f3ff) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/711280.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-13T18:43:19Z

Message from jub0bs:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-14T18:37:22Z

Message from jub0bs:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-14T18:53:14Z

Message from Sean Liao:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-15T19:31:52Z

Message from jub0bs:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-15T20:10:25Z

Message from Sean Liao:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-15T21:05:18Z

Message from t hepudds:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-16T00:08:05Z

Message from Damien Neil:

Patch Set 2: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T13:33:00Z

Message from jub0bs:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T14:28:12Z

This PR (HEAD: 3dc5182) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/711280.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-17T14:45:53Z

Message from jub0bs:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T14:54:20Z

Message from t hepudds:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T14:54:20Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-17T14:42:42Z","revision":"b024213d10bda1ac4e9ee045ef67fc68b1afde89"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T14:54:21Z

Message from t hepudds:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T14:54:22Z

Message from Sean Liao:

Patch Set 3: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T15:12:18Z

Message from t hepudds:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T15:12:18Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T15:12:19Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T16:38:03Z

Message from Emmanuel Odeke:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T07:26:55Z

This PR (HEAD: f6442a6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/711280.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-18T18:20:18Z

Message from t hepudds:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T18:47:02Z

This PR (HEAD: 3475f2e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/711280.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-18T18:54:51Z

Message from jub0bs:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T18:54:52Z

Message from t hepudds:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T19:17:53Z

Message from Jes Cok:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T19:25:32Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-18T19:07:47Z","revision":"a7060b5e7afd4594212d32bccfa8c193a143638d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T19:25:33Z

Message from Jes Cok:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T19:25:33Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-race has failed with summary (view all results):

go on master (change 711280)

To reproduce, try gomote repro 8700645916464025937.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T19:25:34Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T19:33:18Z

This PR (HEAD: f25be71) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/711280.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-18T19:48:32Z

Message from t hepudds:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T19:48:33Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-18T19:34:18Z","revision":"2208e55f14ff63636e48210901e2684465c02566"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T20:03:53Z

Message from t hepudds:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T20:03:54Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T20:03:54Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T20:03:55Z

Message from t hepudds:

Patch Set 6: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T20:03:55Z

Message from jub0bs:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

src/net/url/url.go

gopherbot · 2025-10-19T10:52:36Z

Message from Florian Lehner:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-19T16:57:13Z

Message from Emmanuel Odeke:

Patch Set 6: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-19T16:57:14Z

Message from Emmanuel Odeke:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-20T21:07:46Z

Message from Keith Randall:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-20T21:16:14Z

Message from Cherry Mui:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/711280.
After addressing review feedback, remember to publish your drafts!

This change adds benchmarks for Encode and reverts what CL 617356 did in this package. At the moment, using maps.Keys in conjunction with slices.Sorted indeed causes a bunch of closures to escape to heap. Moreover, all other things being equal, pre-sizing the slice in which we collect the keys is beneficial to performance when they are "many" (>8) keys because it results in fewer allocations than if we don't pre-size the slice. Here are some benchmark results: goos: darwin goarch: amd64 pkg: net/url cpu: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz │ old │ new │ │ sec/op │ sec/op vs base │ EncodeQuery/#00-8 2.051n ± 1% 2.343n ± 1% +14.24% (p=0.000 n=20) EncodeQuery/#1-8 2.337n ± 1% 2.458n ± 4% +5.16% (p=0.000 n=20) EncodeQuery/oe=utf8&q=puppies-8 489.6n ± 0% 284.5n ± 0% -41.88% (p=0.000 n=20) EncodeQuery/q=dogs&q=%26&q=7-8 397.2n ± 1% 231.7n ± 1% -41.66% (p=0.000 n=20) EncodeQuery/a=a1&a=a2&a=a3&b=b1&b=b2&b=b3&c=c1&c=c2&c=c3-8 743.1n ± 0% 519.0n ± 0% -30.16% (p=0.000 n=20) EncodeQuery/a=a&b=b&c=c&d=d&e=e&f=f&g=g&h=h&i=i-8 1324.0n ± 0% 931.0n ± 0% -29.68% (p=0.000 n=20) geomean 98.57n 75.38n -23.53% │ old │ new │ │ B/op │ B/op vs base │ EncodeQuery/#00-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹ EncodeQuery/#1-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹ EncodeQuery/oe=utf8&q=puppies-8 168.00 ± 0% 56.00 ± 0% -66.67% (p=0.000 n=20) EncodeQuery/q=dogs&q=%26&q=7-8 112.00 ± 0% 32.00 ± 0% -71.43% (p=0.000 n=20) EncodeQuery/a=a1&a=a2&a=a3&b=b1&b=b2&b=b3&c=c1&c=c2&c=c3-8 296.0 ± 0% 168.0 ± 0% -43.24% (p=0.000 n=20) EncodeQuery/a=a&b=b&c=c&d=d&e=e&f=f&g=g&h=h&i=i-8 680.0 ± 0% 264.0 ± 0% -61.18% (p=0.000 n=20) geomean ² -47.48% ² ¹ all samples are equal ² summaries must be >0 to compute geomean │ old │ new │ │ allocs/op │ allocs/op vs base │ EncodeQuery/#00-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹ EncodeQuery/#1-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹ EncodeQuery/oe=utf8&q=puppies-8 8.000 ± 0% 3.000 ± 0% -62.50% (p=0.000 n=20) EncodeQuery/q=dogs&q=%26&q=7-8 7.000 ± 0% 3.000 ± 0% -57.14% (p=0.000 n=20) EncodeQuery/a=a1&a=a2&a=a3&b=b1&b=b2&b=b3&c=c1&c=c2&c=c3-8 10.000 ± 0% 5.000 ± 0% -50.00% (p=0.000 n=20) EncodeQuery/a=a&b=b&c=c&d=d&e=e&f=f&g=g&h=h&i=i-8 12.000 ± 0% 5.000 ± 0% -58.33% (p=0.000 n=20) geomean ² -43.23% ² ¹ all samples are equal ² summaries must be >0 to compute geomean Change-Id: Ia0d7579f90434f0546d93b680ab18b47a1ffbdac GitHub-Last-Rev: f25be71 GitHub-Pull-Request: #75874 Reviewed-on: https://go-review.googlesource.com/c/go/+/711280 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Florian Lehner <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Sean Liao <[email protected]> Reviewed-by: t hepudds <[email protected]>

gopherbot · 2025-10-20T21:23:53Z

This PR is being closed because golang.org/cl/711280 has been merged.

austinderek mentioned this pull request Oct 13, 2025

net/url: reduce allocs in Encode PullRequestInc/go#107

Closed

jub0bs force-pushed the optimize-url-encode branch from 38a1551 to 569f3ff Compare October 13, 2025 18:31

jub0bs force-pushed the optimize-url-encode branch from 569f3ff to 3dc5182 Compare October 17, 2025 14:25

jub0bs force-pushed the optimize-url-encode branch from 3dc5182 to f6442a6 Compare October 18, 2025 07:22

jub0bs force-pushed the optimize-url-encode branch from f6442a6 to 3475f2e Compare October 18, 2025 18:42

net/url: add benchmarks for Encode

a638f41

net/url: eschew iterators in Encode

f25be71

jub0bs force-pushed the optimize-url-encode branch from 3475f2e to f25be71 Compare October 18, 2025 19:26

dzbarsky reviewed Oct 18, 2025

View reviewed changes

src/net/url/url.go Show resolved Hide resolved

gopherbot closed this Oct 20, 2025

net/url: reduce allocs in Encode #75874

net/url: reduce allocs in Encode #75874

Conversation

jub0bs commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 13, 2025

Uh oh!

gopherbot commented Oct 14, 2025

Uh oh!

gopherbot commented Oct 14, 2025

Uh oh!

gopherbot commented Oct 15, 2025

Uh oh!

gopherbot commented Oct 15, 2025

Uh oh!

gopherbot commented Oct 15, 2025

Uh oh!

gopherbot commented Oct 16, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 17, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

gopherbot commented Oct 18, 2025

Uh oh!

jub0bs commented Oct 13, 2025 •

edited

Loading