Conversation
The IANA charset GB2312 (MIBenum 2025) resolved to no encoding even though its aliases were already registered, because the encodings table had no entry for it. Map it to GBK, of which GB2312 is a subset, matching x/text's htmlindex which maps every GB2312 label to GBK. Wrap the encoding so it reports MIB 2025 and the name GB2312 rather than GBK's own identifier. Fixes golang/go#24636
Contributor
|
This PR (HEAD: c067b18) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/829705. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IANA charset GB2312 (MIBenum 2025) resolved to no encoding even
though its aliases were already registered, because the encodings
table had no entry for it.
Map it to GBK, of which GB2312 is a subset, matching x/text's
htmlindex which maps every GB2312 label to GBK. Wrap the encoding so
it reports MIB 2025 and the name GB2312 rather than GBK's own
identifier.
Fixes golang/go#24636