Skip to content

encoding/ianaindex: support the GB2312 charset - #71

Open
larrasket wants to merge 1 commit into
golang:masterfrom
larrasket:fix-24636-ianaindex-gb2312
Open

larrasket wants to merge 1 commit into
golang:masterfrom
larrasket:fix-24636-ianaindex-gb2312

Conversation

@larrasket

Copy link
Copy Markdown

The IANA charset GB2312 (MIBenum 2025) resolved to no encoding even
though its aliases were already registered, because the encodings
table had no entry for it.

Map it to GBK, of which GB2312 is a subset, matching x/text's
htmlindex which maps every GB2312 label to GBK. Wrap the encoding so
it reports MIB 2025 and the name GB2312 rather than GBK's own
identifier.

Fixes golang/go#24636

The IANA charset GB2312 (MIBenum 2025) resolved to no encoding even
though its aliases were already registered, because the encodings table
had no entry for it.

Map it to GBK, of which GB2312 is a subset, matching x/text's htmlindex
which maps every GB2312 label to GBK. Wrap the encoding so it reports
MIB 2025 and the name GB2312 rather than GBK's own identifier.

Fixes golang/go#24636
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: c067b18) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/text/+/829705.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/text: ianaindex returns no encoding for gb2312

2 participants