-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add ptrequality linter #5870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add ptrequality linter #5870
Conversation
In order for a pull request adding a linter to be reviewed, the linter and the PR must follow some requirements.
Pull Request Description
Linter
The Linter Tests Inside Golangci-lint
|
The same problem exists as in your previous PR: the linter's name is inaccurate. |
Suggest a good name, then. Two hard things, you know… |
Your linter is detecting pointers used within equality, so I suggest something like: |
You must rename your module, your analyzer, and your repository. |
4291cde
to
d6be453
Compare
ptrequality is a Go linter (static analysis tool) that detects comparisons against the address of newly created values, such as ptr == &MyStruct{} or ptr == new(MyStruct). https://github.com/fillmore-labs/ptrequality Signed-off-by: Oliver Eikemeier <[email protected]>
d6be453
to
1430f05
Compare
This is not what I asked for:
I don't know why you are doing that, but I will not allow this type of wrapper. If you don't want to rename, say it, but don't try to fool me. |
ptrequality
detects comparisons against the address of newly created values, such asptr == &MyStruct{}
orptr == new(MyStruct)
.https://github.com/fillmore-labs/ptrequality