-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr: hello_nrf91_offloaded: document hexstring #733
base: main
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit 2f80462): https://golioth-firmware-sdk-doxygen-dev--pr733-szczys-offload-ku5hkzll.web.app (expires Fri, 31 Jan 2025 17:05:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
@@ -49,8 +49,16 @@ AT%CMNG=3,515765868,3 | |||
Execute following AT commands over serial to provision new credentials: | |||
|
|||
``` sh | |||
AT%CMNG=0,515765868,4,my-psk-id | |||
AT%CMNG=0,515765868,3,my-psk-encoded-as-hexstring | |||
AT%CMNG=0,515765868,4,"my-psk-id" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szczys when issuing the AT commands via nrf_modem_at
below should the PSK / PSK ID also be surrounded by ""
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing, yes they should be. Without them the modem returns ERROR. The Nordic AT command reference shows double quotes wrapping the credentials (page 45)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I retested this and it does indeed work without double-quotes. I've removed them, thanks for raising the issue.
Note: the PSK *must* be encoded as hexadecimal values. One way to | ||
convert your ASCII-encoded PSK is to use the following Linux command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the confusion isn't so much that the PSK needs to be hex, as it is that the value displayed in the Console isn't hex.
Clarify how sending credentials to the nrf91 modem: - Add double quotes around PSK-ID and PSK - Add sample command to illustrate how to hex-encode an ASCII string Signed-off-by: Mike Szczys <[email protected]>
62cac32
to
2f80462
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Clarify how sending credentials to the nrf91 modem: