port: fix memory leak in SHA256 #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mbedtls_sha256_free()` does not free memory, it only zeroes out the SHA context struct. Signed-off-by: Sam Friedman <[email protected]>
|
Visit the preview URL for this PR (updated for commit cc5d1b9): https://golioth-firmware-sdk-doxygen-dev--pr748-sha-memory-lea-51foeh1b.web.app (expires Fri, 21 Feb 2025 21:13:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
mniestroj
approved these changes
Feb 15, 2025
hasheddan
approved these changes
Feb 15, 2025
szczys
approved these changes
Feb 15, 2025
Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mbedtls_sha256_free()does not free memory, it only zeroes out the SHA context struct.