Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repeat args from sub-func call #2034

Closed
wants to merge 1 commit into from

Conversation

alingse
Copy link

@alingse alingse commented Mar 12, 2025

return math.Max(math.Abs(enrmin-1), math.Abs(enrmin-1))

is a copyandpaste bug

Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbinet sbinet requested review from kortschak and vladimir-ch March 13, 2025 08:16
@kortschak
Copy link
Member

kortschak commented Mar 13, 2025

I'm not a fan of being a research subject. There was a similar pr by another person. TBH, I'd prefer that these were issues rather than PRs.

@alingse
Copy link
Author

alingse commented Mar 13, 2025

I'm not a fan of being a research subject. There was a similar pr by another person. TBH, I'd prefer that these were issues rather than PRs.

this is a little bug, I change the description of this PR

@kortschak
Copy link
Member

The reason that I'd prefer issues for things like this is that for this change we need two PRs, one for this change and one for the A+C change that we require for the project. This was done for this change in #2032 and #2033 which for the commit message format matches our convention.

@alingse
Copy link
Author

alingse commented Mar 13, 2025

@kortschak thx, I forget to search the exists PR I will close this

@alingse alingse closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants