This repository was archived by the owner on Oct 13, 2025. It is now read-only.
don't pin dependencies to specific versions#8
Open
jjallaire wants to merge 1 commit intogoodfire-ai:mainfrom
Open
don't pin dependencies to specific versions#8jjallaire wants to merge 1 commit intogoodfire-ai:mainfrom
jjallaire wants to merge 1 commit intogoodfire-ai:mainfrom
Conversation
rather, allow the same versions or any greater version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather, allow the same versions or any greater version. This will resolve #3.
Here is some additional discussion on why hard pinning or upper bounding version constraints can end up in a dead end where packages don't work together: https://iscinumpy.dev/post/bound-version-constraints/.
Note that currently installing
goodfireresults in a pip error when installing eithermistralaiorgoogle-genai(both of which require httpx >= 0.28 whereasgoodfireis pinned at 0.27.2.This will enable us to restore the Goodfire provider to Inspect AI: UKGovernmentBEIS/inspect_ai#2170