Compare text generations of simplestories models#254
Open
leesharkey wants to merge 33 commits intomainfrom
Open
Compare text generations of simplestories models#254leesharkey wants to merge 33 commits intomainfrom
leesharkey wants to merge 33 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new script
spd/scripts/compare_generations/compare_generations.pythat enables qualitative comparison of text generations from different model configurations. The script generates and displays side-by-side comparisons of:The script loads models from wandb run IDs (or local paths), generates text autoregressively, and displays results both in the terminal and saves them to JSON for further analysis.
Key features:
Related Issue
N/A - New feature addition
Motivation and Context
This script addresses the need for qualitative evaluation and comparison of different SPD model configurations. It allows researchers to:
The script is designed to be simple and maintainable, making it easy to understand and modify for different use cases.
How Has This Been Tested?
The script has been tested with:
wandb:goodfire/spd/runs/9gf5ud48and `5cdomlyn'Test results:
Does this PR introduce a breaking change?
No, this is a new script addition and does not modify any existing functionality. It only adds new files:
spd/scripts/compare_generations/compare_generations.pyspd/scripts/compare_generations/compare_generations_config.yamlspd/scripts/compare_generations/README.md.vscode/launch.json(debugger configuration)No existing code paths are affected.