Refactor plot_component_activations into standard script directory#404
Open
lee-goodfire wants to merge 1 commit intodevfrom
Open
Refactor plot_component_activations into standard script directory#404lee-goodfire wants to merge 1 commit intodevfrom
lee-goodfire wants to merge 1 commit intodevfrom
Conversation
…ructure Move from bare file (spd/scripts/plot_component_activations.py) into its own subdirectory, matching the convention used by all other scripts. Switch from argparse to fire, accept wandb_path instead of bare run_id, use logger instead of print. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
spd/scripts/plot_component_activations.pyfrom a bare file into its own subdirectory (spd/scripts/plot_component_activations/), matching the convention used by all other scripts.Changes:
argparse→firerun_idarg →wandb_path: ModelPathprint→loggerSCRIPT_DIR / "out" / run_id(co-located with the script)Motivation and Context
This was the only script in
spd/scripts/that didn't follow the standard subdirectory pattern, causing its outputs to land in a different location from all other scripts.How Has This Been Tested?
Smoke-tested plotting functions with synthetic data. Type checks pass.
Does this PR introduce a breaking change?
No, but the module path changes from
spd.scripts.plot_component_activationstospd.scripts.plot_component_activations.plot_component_activations.🤖 Generated with Claude Code