Simplify investigate module + deduplicate constant#434
Merged
ocg-goodfire merged 3 commits intodevfrom Mar 6, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- run_agent reads all config from metadata.json instead of duplicating as CLI args (wandb_path, context_length, max_turns) - wait_for_backend raises directly instead of returning bool - _format_model_info accesses keys directly instead of .get() fallbacks Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_agent: reads all config frommetadata.jsoninstead of duplicatingwandb_path,context_length,max_turnsas CLI argswait_for_backend: raisesRuntimeErroron timeout instead of returningbool_format_model_info: accesses dict keys directly instead of.get()with silent fallbackscontext_length=128andmax_turns=50defaults fromrun_agent(already defaulted in CLI)MAX_OUTPUT_NODES_PER_POS: import fromcompute.pyinstead of redefining ingraphs.pyTest plan
basedpyrightpasses on affected files (0 errors, 0 warnings)🤖 Generated with Claude Code