Skip to content

docs: fix API key name in digital-payment-credentials README#205

Open
dzuluaga wants to merge 1 commit intogoogle-agentic-commerce:mainfrom
dzuluaga:fix/readme-gemini-api-key
Open

docs: fix API key name in digital-payment-credentials README#205
dzuluaga wants to merge 1 commit intogoogle-agentic-commerce:mainfrom
dzuluaga:fix/readme-gemini-api-key

Conversation

@dzuluaga
Copy link
Copy Markdown

Summary

  • The README instructed users to set GOOGLE_API_KEY in local.properties, but build.gradle.kts reads GEMINI_API_KEY. This mismatch caused a 403 PERMISSION_DENIED error when the Android app called the Gemini API with an empty key.
  • Updated the README to use GEMINI_API_KEY for local.properties

Test plan

  • Followed the updated README instructions with GEMINI_API_KEY in local.properties
  • Verified the Android app successfully calls the Gemini API without 403 errors

Fixes #204

The README instructed users to set GOOGLE_API_KEY in local.properties,
but build.gradle.kts reads GEMINI_API_KEY. This mismatch caused a 403
PERMISSION_DENIED error when the Android app called the Gemini API
with an empty key.

Signed-off-by: Diego Zuluaga <[email protected]>
@dzuluaga dzuluaga requested a review from a team as a code owner March 30, 2026 01:37
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README for the digital-payment-credentials scenario to use GEMINI_API_KEY instead of GOOGLE_API_KEY. A review comment points out that the file path in the setup instructions incorrectly references the shopping_assistant project directory instead of the digital-payment-credentials directory.

```
echo "GOOGLE_API_KEY=your_key" >> samples/android/shopping_assistant/local.properties
echo "GEMINI_API_KEY=your_key" >> samples/android/shopping_assistant/local.properties
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file path samples/android/shopping_assistant/local.properties seems incorrect as this README.md is located in samples/android/scenarios/digital-payment-credentials/. Assuming the commands are run from the repository root, the path to the shopping_assistant project's local.properties file should be samples/android/shopping_assistant/local.properties.

However, the current path is samples/android/shopping_assistant/local.properties, which seems to be a typo. It should likely be samples/android/shopping_assistant/local.properties to correctly target the shopping_assistant project's properties file from the repository root. This same potential typo exists for the sdk.dir command below.

@dzuluaga
Copy link
Copy Markdown
Author

Lint failures are pre-existing on main (MD030/MD040 in this README). This PR only changes the API key name on lines 50-54.

@dzuluaga
Copy link
Copy Markdown
Author

Re: gemini-code-assist feedback — The path samples/android/shopping_assistant/local.properties is correct. The README instructions are intended to be run from the repository root.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Thank you for the clarification, @dzuluaga. That makes sense regarding the intended execution context for the README instructions. I have noted that the lint failures are pre-existing and unrelated to these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: README uses wrong API key name for local.properties

1 participant