docs: fix API key name in digital-payment-credentials README#205
docs: fix API key name in digital-payment-credentials README#205dzuluaga wants to merge 1 commit intogoogle-agentic-commerce:mainfrom
Conversation
The README instructed users to set GOOGLE_API_KEY in local.properties, but build.gradle.kts reads GEMINI_API_KEY. This mismatch caused a 403 PERMISSION_DENIED error when the Android app called the Gemini API with an empty key. Signed-off-by: Diego Zuluaga <[email protected]>
There was a problem hiding this comment.
Code Review
This pull request updates the README for the digital-payment-credentials scenario to use GEMINI_API_KEY instead of GOOGLE_API_KEY. A review comment points out that the file path in the setup instructions incorrectly references the shopping_assistant project directory instead of the digital-payment-credentials directory.
| ``` | ||
| echo "GOOGLE_API_KEY=your_key" >> samples/android/shopping_assistant/local.properties | ||
| echo "GEMINI_API_KEY=your_key" >> samples/android/shopping_assistant/local.properties |
There was a problem hiding this comment.
The file path samples/android/shopping_assistant/local.properties seems incorrect as this README.md is located in samples/android/scenarios/digital-payment-credentials/. Assuming the commands are run from the repository root, the path to the shopping_assistant project's local.properties file should be samples/android/shopping_assistant/local.properties.
However, the current path is samples/android/shopping_assistant/local.properties, which seems to be a typo. It should likely be samples/android/shopping_assistant/local.properties to correctly target the shopping_assistant project's properties file from the repository root. This same potential typo exists for the sdk.dir command below.
|
Lint failures are pre-existing on |
|
Re: gemini-code-assist feedback — The path |
|
Thank you for the clarification, @dzuluaga. That makes sense regarding the intended execution context for the README instructions. I have noted that the lint failures are pre-existing and unrelated to these changes. |
Summary
GOOGLE_API_KEYinlocal.properties, butbuild.gradle.ktsreadsGEMINI_API_KEY. This mismatch caused a 403 PERMISSION_DENIED error when the Android app called the Gemini API with an empty key.GEMINI_API_KEYforlocal.propertiesTest plan
GEMINI_API_KEYinlocal.propertiesFixes #204