Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Escape + and ; in resource names.#22

Open
donghanmiao wants to merge 1 commit intomasterfrom
patch
Open

Escape + and ; in resource names.#22
donghanmiao wants to merge 1 commit intomasterfrom
patch

Conversation

@donghanmiao
Copy link
Contributor

Also, escape resource names for the integration tests.

Bug: 110212500
Bug: 130297436
Bug: 133445325
Bug: 133830687
Change-Id: I045b1987537c6f2ced15ad48f0f40d1c320af326

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

Also, escape resource names for the integration tests.

Bug: 110212500
Bug: 130297436
Bug: 133445325
Bug: 133830687
Change-Id: I045b1987537c6f2ced15ad48f0f40d1c320af326
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@wiarlawd
Copy link
Contributor

Abandoned due to b/137796085. Will replace with complete list of cherry-picks, including the fix.

@wiarlawd wiarlawd closed this Jul 31, 2019
@wiarlawd wiarlawd deleted the patch branch July 31, 2019 23:28
@wiarlawd wiarlawd restored the patch branch July 31, 2019 23:33
@wiarlawd wiarlawd reopened this Jul 31, 2019
@wiarlawd
Copy link
Contributor

DO NOT MERGE, replaced by #25

@wiarlawd wiarlawd closed this Jul 31, 2019
@wiarlawd wiarlawd reopened this Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants