Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Building MuJoCo from Source Using Bazel #2186

Closed
bd-jahn opened this issue Oct 28, 2024 · 3 comments
Closed

Support for Building MuJoCo from Source Using Bazel #2186

bd-jahn opened this issue Oct 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@bd-jahn
Copy link

bd-jahn commented Oct 28, 2024

The feature, motivation and pitch

Hello MuJoCo Team,

Our team has been integrating MuJoCo within a larger Bazel project. Currently, we fetch and link the prebuilt release binaries from this repository for C++ projects and download mujoco-py from PyPI for Python projects.

While this setup works well in most cases, we’d like to build the libraries directly using Bazel for several reasons, including hermeticity, reducing ODR issues from common dependencies, and improved integration with our existing infrastructure. I’ve developed an initial proof of concept that compiles libmujoco.so using Bazel targeting Ubuntu 22.04 / x86 configuration, and I’m open to contributing it to the community.

I understand that the current CMake build system is more comprehensive, supporting a range of configurations and Python bindings, but I wanted to get your guidance before proceeding further.

Thank you!

Alternatives

No response

Additional context

No response

@bd-jahn bd-jahn added the enhancement New feature or request label Oct 28, 2024
@yuvaltassa
Copy link
Collaborator

We would love to accept this contribution.
Please send us a PR, we look forward to it!
Closing for now, let's continue the conversation in the PR 🙂

@bd-jahn
Copy link
Author

bd-jahn commented Nov 11, 2024

Hi @yuvaltassa
I wanted to open a PR to the upstream repository, but my patches were based on v3.2.2. Since there’s no branch in the upstream repository associated with commit 5383d1c, I wasn’t able to create the PR there. Instead, I opened a PR in my forked repository. Please let me know if there’s a better way to track this.

@bd-jahn
Copy link
Author

bd-jahn commented Nov 12, 2024

I managed to rebase the branch onto main and opened #2225. Let's continue the conversation in the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants