[#1196] renaming tree_scalar_mul to tree_scale and tree_add_scalar_mul to tree_add_scale #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR renames the functions tree_scalar_mul to tree_scale and tree_add_scalar_mul to tree_add_scale for improved clarity and conciseness. The old function names are kept as aliases, but now emit deprecation warnings.
Why are the changes needed?
The new names provide a more intuitive and concise representation of the functions’ purpose. The deprecation warnings alert users about the future removal of the old names after a suitable deprecation period.
Fix: #1196
Does this PR introduce any user-facing change?
No, this change is backward-compatible. Users will receive deprecation warnings when using the old function names, but no immediate functionality change occurs.
How was this patch tested?
The changes were verified by ensuring that the old function names now trigger deprecation warnings and that the renamed functions behave as expected.