Align proto primitives #187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlazo
requested changes
Jul 3, 2024
common/src/main/kotlin/com/google/ai/client/generativeai/common/shared/Types.kt
Outdated
Show resolved
Hide resolved
common/src/main/kotlin/com/google/ai/client/generativeai/common/shared/Types.kt
Show resolved
Hide resolved
common/src/main/kotlin/com/google/ai/client/generativeai/common/shared/Types.kt
Show resolved
Hide resolved
common/src/main/kotlin/com/google/ai/client/generativeai/common/shared/Types.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/346838276,
This better aligns our serialization with the default behavior of the proto. More specifically- primitive defaults, and empty lists. Other default behaviors could be addressed as well- such as
UNSPECIFIEDfor enum values, but that has been put off for now as it will have design implications (eg;FinishReasonno longer being null).This PR also fixes the following:
b/350773404 -> Stop using snake case serial names