Update text_generation.dart #213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
requested changes
Sep 16, 2024
Collaborator
natebosch
left a comment
natebosch
left a comment
There was a problem hiding this comment.
What is the background to this change?
|
|
||
| final apiKey = () { | ||
| final apiKey = Platform.environment['GEMINI_API_KEY']; | ||
| final apiKey = Platform.environment['GOOGLE_API_KEY']; |
Collaborator
There was a problem hiding this comment.
My understanding is that GEMINI_API_KEY is the standard across the SDKS.
|
|
||
| Future<void> textGenTextOnlyPrompt() async { | ||
| // [START text_gen_text_only_prompt] | ||
| import 'package:google_generative_ai/google_generative_ai.dart'; |
Collaborator
There was a problem hiding this comment.
This is not valid Dart. Imports may only be at the beginning of a library.
Collaborator
|
#214 adds the imports in comments in each sample. Does that address your intentions with this change? That looks like what the JS SDK is doing. |
iqbalbhatti49
left a comment
iqbalbhatti49
left a comment
There was a problem hiding this comment.
Review Comments:
- The environment variable was updated from
GEMINI_API_KEYtoGOOGLE_API_KEY, aligning with platform conventions. - Initialization of the
GenerativeModeland the example prompt were added, making the code more comprehensive and user-friendly. Great addition! - Error handling has been streamlined, and meaningful output (
No $GOOGLE_API_KEY environment variable) improves debugging.
This update is well-executed and enhances functionality—nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.