-
Notifications
You must be signed in to change notification settings - Fork 196
Add Prerelease option for release #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prerelease option for release #77
Conversation
Signed-off-by: Xuejie(Alicia) Tang <[email protected]>
Signed-off-by: Xuejie(Alicia) Tang <[email protected]>
| { | ||
| "name": "run-gemini-cli", | ||
| "version": "0.1.0", | ||
| "version": "0.1.0-beta.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this as "0.1.0" for now. When you trigger the release action, the automation will create a PR that re-compiles all the JS and updates this file. If you commit as-is, then when you release, it will create 0.1.0-beta.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want a release tag with beta right? if keeping the current version, it will not have a tag as beta version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aliciatang07 yes, but they will happen when you trigger the "draft-release" GitHub Action.
- Draft Release creates a PR that bumps the package.json and recompiles all the JS/TS
- Merging that PR does an actual release on GitHub (with the version information from the PR)
I just did it this morning on another repo, so you can see what I mean:
- I ran the Draft Release workflow, which created Release: v2.1.12 auth#503
- I merged Release: v2.1.12 auth#503, which triggered the release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I know if we didn't change the version, when running the draft release action, we will have a release with tag v0.1.1, is that what we want? I thought we want a tag with beta version. @jerop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. Keep the change in "draft-release.yml" to allow the "prerelease" drop-down item. Revert the change to package.json though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we want a tag with beta version
@aliciatang07 what i meant is that we want a tag named 'beta' in here: https://github.com/google-github-actions/run-gemini-cli/tags (much like the 'latest' label)
but the release itself uses semantic versioning with MAJOR.MINOR.PATCH format

No description provided.