fix: render primitive types from spec config#131
Open
juliosuas wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rajpratham1
approved these changes
Jun 27, 2026
rajpratham1
left a comment
There was a problem hiding this comment.
This is a well-structured refactor that moves primitive type definitions into the shared spec configuration instead of duplicating them inside the generated documentation. It improves maintainability, keeps the specification as a single source of truth, and includes appropriate validation and regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97. Moves primitive type definitions into spec-config.yaml and renders them through the spec generator, so Color and Dimension are driven by the same config source as sections, units, typography properties, and component sub-tokens. Validation: focused spec-config/spec-gen tests passed; generate --check passed; full bun run test, bun run lint, bun run build, and git diff --check passed.