Skip to content

Comments

Introduce tool.WithConfirmation. #579

Open
caglar10ur wants to merge 2 commits intogoogle:mainfrom
caglar10ur:confirmation
Open

Introduce tool.WithConfirmation. #579
caglar10ur wants to merge 2 commits intogoogle:mainfrom
caglar10ur:confirmation

Conversation

@caglar10ur
Copy link
Contributor

It wraps a toolset to inject confirmation logic in each tool after they created.

…ation logic in each tool after they created.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @caglar10ur, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new WithConfirmation function that allows developers to wrap existing toolsets with human-in-the-loop confirmation logic. This enhancement provides a mechanism to prompt for user approval before a tool's execution, improving control and safety for critical operations. Additionally, common tool packaging logic has been extracted into a utility function, streamlining the ProcessRequest implementation across tools.

Highlights

  • Human-in-the-Loop (HITL) Confirmation: Introduced tool.WithConfirmation to wrap toolsets and inject confirmation logic into individual tools, enabling user approval before tool execution.
  • Tool Processing Refactoring: Refactored the ProcessRequest method in agentTool to delegate common tool packing logic to a new utility function, toolutils.PackTool.
  • Comprehensive Testing: Added a new test suite, TestWithConfirmation, to thoroughly validate the various scenarios and behaviors of the new confirmation mechanism.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tool/agenttool/agent_tool.go
    • Imported toolutils package.
    • Refactored ProcessRequest to use toolutils.PackTool for handling tool declarations.
  • tool/tool.go
    • Updated copyright year to 2026.
    • Introduced ConfirmationProvider type for dynamic confirmation logic.
    • Added WithConfirmation function to wrap a Toolset with confirmation capabilities.
    • Implemented confirmationToolset and confirmationTool structs to manage and apply confirmation logic.
    • Defined runnableTool and requestProcessor interfaces for internal use.
    • Integrated confirmation checks within the Run method of confirmationTool, including handling ToolConfirmation from context and requesting confirmation when necessary.
  • tool/tool_test.go
    • Added necessary imports for testing the new confirmation features.
    • Created testContext and testToolset mock implementations for testing.
    • Implemented TestWithConfirmation with multiple test cases to validate confirmation behavior, including successful runs, rejections, and dynamic confirmation via a provider.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a WithConfirmation wrapper for toolsets, which is a great feature for adding a human-in-the-loop confirmation step for tool execution. The implementation is clean and the addition of a ConfirmationProvider for dynamic confirmation logic is a nice touch. The new functionality is also well-tested. I've found one minor issue regarding some unused code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants