Skip to content

fix: use session.NewEvent in generateRequestConfirmationEvent #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohamedabozeid wants to merge 1 commit into from
+16 −14
Closed

fix: use session.NewEvent in generateRequestConfirmationEvent #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions internal/llminternal/functions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
package llminternal

import (
"time"

"google.golang.org/genai"

"google.golang.org/adk/agent"
Expand Down Expand Up @@ -78,18 +76,15 @@ func generateRequestConfirmationEvent(
return nil
}

return &session.Event{
InvocationID: invocationContext.InvocationID(),
Author: invocationContext.Agent().Name(),
Branch: invocationContext.Branch(),
LLMResponse: model.LLMResponse{
Content: &genai.Content{
Parts: parts,
Role: genai.RoleModel,
},
event := session.NewEvent(invocationContext.InvocationID())
event.Author = invocationContext.Agent().Name()
event.Branch = invocationContext.Branch()
event.LLMResponse = model.LLMResponse{
Content: &genai.Content{
Parts: parts,
Role: genai.RoleModel,
},
Timestamp: time.Now(),
LongRunningToolIDs: longRunningToolIDs,
Actions: session.EventActions{},
}
Comment on lines +82 to 87
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since session.Event embeds model.LLMResponse, you can set the Content field directly on the event object. This avoids the explicit model.LLMResponse struct literal, making the code a little more direct.

For example:

event.Content = &genai.Content{
    Parts: parts,
    Role:  genai.RoleModel,
}

This is functionally equivalent to the current implementation because session.NewEvent already zero-initializes the embedded model.LLMResponse struct.

event.LongRunningToolIDs = longRunningToolIDs
return event
}
7 changes: 7 additions & 0 deletions internal/llminternal/functions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ func TestGenerateRequestConfirmationEvent(t *testing.T) {
InvocationID: "inv_1",
Author: "agent_1",
Branch: "main",
Actions: session.EventActions{StateDelta: map[string]any{}},
LLMResponse: model.LLMResponse{
Content: &genai.Content{
Role: genai.RoleModel,
Expand Down Expand Up @@ -180,6 +181,12 @@ func TestGenerateRequestConfirmationEvent(t *testing.T) {
}

if got != nil {
if got.ID == "" {
t.Errorf("expected event ID to be set, got empty string")
}
if got.Timestamp.IsZero() {
t.Errorf("expected event Timestamp to be set, got zero value")
}
for _, s := range got.LongRunningToolIDs {
if s == "" {
t.Errorf("empty long running tool id")
Expand Down