feat: Add session_service_db_kwargs to get_fast_api_app #1800
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabaseSessionService init to allow more configuration for session service in production
|
it seems that this PR is incomplete. I didn't see the caller of get_fast_api_app is updated. How could this new parameter passed by the developer ? |
miko-garrido
commented
Jul 12, 2025
| @@ -213,6 +213,7 @@ def get_fast_api_app( | |||
| *, | |||
| agents_dir: str, | |||
| session_service_uri: Optional[str] = None, | |||
| session_service_db_kwargs: Optional[dict[str, Any]] = None, | |||
There was a problem hiding this comment.
The session_service_db_kwargs are here @seanzhou1023
Dev can pass kwargs as argument via the get_fast_api_app function
There was a problem hiding this comment.
Hey @seanzhou1023 @hangfei - the arguments are passed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few lines to add
session_service_db_kwargstoget_fast_api_appparameters, and then pass them to the session_service object created via DatabaseSessionService.Based on issue #1287