Disable cvdalloc if iptables cannot be resolved.#2526
Merged
Conversation
3405691582
force-pushed
the
488432653_4
branch
2 times, most recently
from
4f79f4c to
dfb1484
Compare
If for whatever reason we cannot resolve the iptables binary from PATH, fall back to non-cvdalloc behavior. This will give a better chance of the instance actually starting up properly, considering that we currently both have statically allocated tap resources being created by cuttlefish-host-resources. This won't be as elegant in a future where we remove the static resource allocation, but we'll cross that bridge when we get to it.
Databean
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If for whatever reason we cannot resolve the iptables binary from PATH, fall back to non-cvdalloc behavior. This will give a better chance of the instance actually starting up properly, considering that we currently both have statically allocated tap resources being created by cuttlefish-host-resources. This won't be as elegant in a future where we remove the static resource allocation, but we'll cross that bridge when we get to it.