Skip to content

Add colors to cvd monitor#2574

Open
Databean wants to merge 1 commit into
google:mainfrom
Databean:refactor-cvd-monitor
Open

Add colors to cvd monitor#2574
Databean wants to merge 1 commit into
google:mainfrom
Databean:refactor-cvd-monitor

Conversation

@Databean
Copy link
Copy Markdown
Member

  • Introduce component-aware syntax highlighting and coloring for logcat, kernel, launcher, and log_tee streams in cvd monitor.
  • Colorize timestamps, subsystem tags, PIDs/TIDs, and verbosity levels to improve log readability and debugging efficiency.
  • Restructure log monitoring logic into decoupled structured parsing and formatting pipelines within a new commands/monitor/ package.
  • Add comprehensive unit tests for parsing and formatting across all supported log stream formats.

Assisted-by: Jetski
Bug: b/513710219

@Databean Databean force-pushed the refactor-cvd-monitor branch from 3a54ca5 to 5f38fd7 Compare May 18, 2026 17:26
Copy link
Copy Markdown
Collaborator

@3405691582 3405691582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by: we should honor NO_COLOR (https://no-color.org/).

@Databean Databean force-pushed the refactor-cvd-monitor branch 2 times, most recently from 64d2685 to bb5da53 Compare May 28, 2026 23:56
@Databean
Copy link
Copy Markdown
Member Author

Databean commented May 28, 2026

Updated to honor NO_COLOR and FORCE_COLOR (https://force-color.org/).

@Databean Databean force-pushed the refactor-cvd-monitor branch 7 times, most recently from ac94970 to a524a70 Compare May 29, 2026 22:45
@Databean Databean requested a review from jemoreira May 29, 2026 22:46
@Databean Databean force-pushed the refactor-cvd-monitor branch from a524a70 to 2f8268b Compare May 29, 2026 22:46
Comment thread base/cvd/cuttlefish/host/commands/cvd/cli/commands/monitor/display.h Outdated
Comment thread base/cvd/cuttlefish/host/commands/cvd/cli/commands/monitor/truncate.cc Outdated
Comment thread base/cvd/cuttlefish/host/commands/cvd/cli/commands/monitor/truncate.cc Outdated
Comment thread base/cvd/cuttlefish/host/commands/cvd/cli/commands/monitor/truncate.cc Outdated
Comment thread base/cvd/cuttlefish/host/commands/cvd/cli/commands/monitor/truncate.cc Outdated
@Databean Databean force-pushed the refactor-cvd-monitor branch 3 times, most recently from 5895fc7 to 237f7ef Compare June 2, 2026 02:07
- Introduce component-aware syntax highlighting and coloring for logcat,
  kernel, launcher, and log_tee streams in `cvd monitor`.
- Colorize timestamps, subsystem tags, PIDs/TIDs, and verbosity levels
  to improve log readability and debugging efficiency.
- Restructure log monitoring logic into decoupled structured parsing
  and formatting pipelines within a new `commands/monitor/` package.
- Add comprehensive unit tests for parsing and formatting across all
  supported log stream formats.

Assisted-by: Jetski
Bug: b/513710219
@Databean Databean force-pushed the refactor-cvd-monitor branch from 237f7ef to 3398c8b Compare June 2, 2026 08:14
@Databean Databean added the kokoro:run Run e2e tests. label Jun 2, 2026
@Databean
Copy link
Copy Markdown
Member Author

Databean commented Jun 2, 2026

Thanks for reviewing!

@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Jun 2, 2026
@Databean Databean added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jun 2, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Jun 2, 2026
@Databean Databean enabled auto-merge June 2, 2026 16:17
@Databean Databean added this pull request to the merge queue Jun 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants