Add colors to cvd monitor#2574
Open
Databean wants to merge 1 commit into
Open
Conversation
3a54ca5 to
5f38fd7
Compare
3405691582
reviewed
May 28, 2026
Collaborator
3405691582
left a comment
There was a problem hiding this comment.
Drive-by: we should honor NO_COLOR (https://no-color.org/).
64d2685 to
bb5da53
Compare
Member
Author
|
Updated to honor |
ac94970 to
a524a70
Compare
a524a70 to
2f8268b
Compare
jemoreira
approved these changes
May 30, 2026
5895fc7 to
237f7ef
Compare
- Introduce component-aware syntax highlighting and coloring for logcat, kernel, launcher, and log_tee streams in `cvd monitor`. - Colorize timestamps, subsystem tags, PIDs/TIDs, and verbosity levels to improve log readability and debugging efficiency. - Restructure log monitoring logic into decoupled structured parsing and formatting pipelines within a new `commands/monitor/` package. - Add comprehensive unit tests for parsing and formatting across all supported log stream formats. Assisted-by: Jetski Bug: b/513710219
237f7ef to
3398c8b
Compare
Member
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cvd monitor.commands/monitor/package.Assisted-by: Jetski
Bug: b/513710219