Skip to content

Invert clang-format default for cuttlefish packages#2655

Merged
Databean merged 1 commit into
google:mainfrom
Databean:enable-clang-format
Jun 4, 2026
Merged

Invert clang-format default for cuttlefish packages#2655
Databean merged 1 commit into
google:mainfrom
Databean:enable-clang-format

Conversation

@Databean
Copy link
Copy Markdown
Member

@Databean Databean commented Jun 3, 2026

  • Change the default of clang_format_enabled to True in rules.bzl.
  • Remove explicit clang_format_enabled = True from compliant targets.
  • Set clang_format_enabled = False for non-compliant targets across the workspace.

Also fix a duplicate header in cvdalloc/BUILD.bazel.

Bug: b/512215781
Assisted-by: gemini-next:current

@Databean Databean requested a review from jemoreira June 3, 2026 21:44
@Databean Databean force-pushed the enable-clang-format branch 2 times, most recently from f20caf5 to a3e242d Compare June 4, 2026 01:41
@Databean Databean changed the title Enable clang-format for formatted targets in cuttlefish Invert clang-format default for cuttlefish packages Jun 4, 2026
@Databean
Copy link
Copy Markdown
Member Author

Databean commented Jun 4, 2026

The original PR applied enable_clang_format = True where possible, it has been changed to instead flip the default and apply enable_clang_format = False to non-compliant files.

The distribution now is:

  • Total cf_cc_* targets: 706
  • Explicitly set to False (clang_format_enabled = False): 242 targets (non-compliant targets).
  • Explicitly set to True: 0 targets (redundant settings removed).
  • Implicitly True (default): 464 targets (compliant targets, using the new default).

@Databean Databean added the kokoro:run Run e2e tests. label Jun 4, 2026
@Databean Databean force-pushed the enable-clang-format branch from a3e242d to 9543311 Compare June 4, 2026 01:47
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Jun 4, 2026
@Databean Databean added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jun 4, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Jun 4, 2026
Change the default of `clang_format_enabled` to `True` in `rules.bzl`.
Remove explicit `clang_format_enabled = True` from compliant targets.
Set `clang_format_enabled = False` for non-compliant targets across the workspace.

Also fix a duplicate header in cvdalloc/BUILD.bazel.

Bug: b/512215781
Assisted-by: gemini-next:current
@Databean Databean force-pushed the enable-clang-format branch from 9543311 to cbc712e Compare June 4, 2026 17:37
@Databean Databean added the kokoro:run Run e2e tests. label Jun 4, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Jun 4, 2026
@Databean Databean added this pull request to the merge queue Jun 4, 2026
Merged via the queue into google:main with commit 734c5fb Jun 4, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants