cvd: Handle broken symlinks in default custom action config#2700
Merged
Conversation
rmuthiah
force-pushed
the
fix-symlink
branch
2 times, most recently
from
e50f773 to
409bceb
Compare
Databean
approved these changes
Jun 15, 2026
When launching older Android trees, the host tools might contain a broken symlink for cuttlefish_example_action_config.json (pointing to a non-existent /usr/lib/cuttlefish-common/... path on the host). Previously, DefaultCustomActionConfig() only checked if the parent directory existed and returned the first .json file found, without verifying if the file itself was accessible. This caused assemble_cvd to abort when trying to read the broken symlink. This change adds a FileExists() check before returning the detected config path. If the file is not accessible (e.g., a broken symlink), it logs a warning and safely ignores it, falling back to an empty custom action configuration and allowing the launch to proceed. Test: Local launch of older tree (simulated with broken symlink) TAG=agy CONV=9c0d5aa1-08b9-492f-a8dd-54472559c2d3
rmuthiah
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When launching older Android trees, the host tools might contain a broken symlink for cuttlefish_example_action_config.json (pointing to a non-existent /usr/lib/cuttlefish-common/... path on the host).
Previously, DefaultCustomActionConfig() only checked if the parent directory existed and returned the first .json file found, without verifying if the file itself was accessible. This caused assemble_cvd to abort when trying to read the broken symlink.
This change adds a FileExists() check before returning the detected config path. If the file is not accessible (e.g., a broken symlink), it logs a warning and safely ignores it, falling back to an empty custom action configuration and allowing the launch to proceed.
Test: Local launch of older tree (simulated with broken symlink)
TAG=agy
CONV=9c0d5aa1-08b9-492f-a8dd-54472559c2d3