Migrate QuestionnaireEditRecyclerview to compose #2884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
- Fixed duplicate ids when using repeated groups - Fixed issues with progress indicator upon scroll - Fixed issues with showing validation errors - Fixed issues with state management on individual lazy column rows that renders form widgets. Tag the created views with the viewholder, and call viewholder bind method to update view content. Signed-off-by: Elly Kitoto <[email protected]>
Every field in a questionnaire is expected to have a unique linkId. Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
jingtang10
requested changes
Oct 8, 2025
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
jingtang10
requested changes
Oct 8, 2025
View holder tagging on on composable views will no longer be necessary once all the views are migrated to compose. Signed-off-by: Elly Kitoto <[email protected]>
In order to prevent LazyColumn id name collisions when repeated groups are nested arbitrarily deep, the questionnaire ID is generated from the string derived from tracking all the accumulated paths from all ancestor repeated groups through recursive calls. Signed-off-by: Elly Kitoto <[email protected]>
7 tasks
Some code from the |
LZRS
reviewed
Oct 14, 2025
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Show resolved
Hide resolved
jingtang10
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2851
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.