Fix a few documentation/spelling nits #1477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to "cargo doc --help", --all is a deprecated alias for --workspace. Fix that, update the test name to one that hasn't been deleted, and use --exact to only run the specified one.
The multiple re-exports of the same item confuses rustdoc, and currently other items that try to link to subclass actually link to the deprecated is_subclass. I reported this bug to rustdoc[1], and a maintainer suggested swapping the re-export order as a workaround. [1] rust-lang/rust#136777
We were losing the brackets around attribute names, since rustdoc saw them as links. Fix that up, and also update a couple links that still pointed to the deprecated is_subclass attribute.
tchebb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details. If you'd each commit in a separate PR I can do that, but I figure merging this without squashing is easier given how small each fix is.