Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make necessary changes to support asymmetric actor critic. #562

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

kevinzakka
Copy link
Contributor

No description provided.

brax/training/agents/ppo/networks.py Outdated Show resolved Hide resolved
brax/training/agents/ppo/train.py Show resolved Hide resolved
@btaba btaba self-assigned this Dec 1, 2024
Copy link
Collaborator

@btaba btaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good, just a few nits

brax/training/agents/ppo/train_test.py Outdated Show resolved Hide resolved
brax/training/agents/ppo/train_test.py Outdated Show resolved Hide resolved
brax/training/networks.py Outdated Show resolved Hide resolved
brax/envs/fast.py Outdated Show resolved Hide resolved
brax/envs/fast.py Outdated Show resolved Hide resolved
brax/training/agents/ppo/train_test.py Outdated Show resolved Hide resolved
@btaba
Copy link
Collaborator

btaba commented Dec 2, 2024

sweet ty 🙌

@btaba btaba merged commit d5eddc2 into google:main Dec 2, 2024
3 checks passed
@kevinzakka kevinzakka deleted the asymmetric-ac branch December 4, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants