Update runtime to correctly handle comprehension vars shadowing root scope. #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_855941509
branch
from
4e8611c to
44e4684
Compare
copybara-service
bot
force-pushed
the
test_855941509
branch
from
44e4684 to
6462862
Compare
…scope. - Comprehension vars should shadow root scope. Before types / enums wouldn't correctly be shadowed. - names with leading dot always resolve at root and don't consider the container. PiperOrigin-RevId: 859166336
copybara-service
bot
force-pushed
the
test_855941509
branch
from
6462862 to
87697f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update runtime to correctly handle comprehension vars shadowing root scope.
correctly be shadowed.