Skip to content

[Tracing] Refactor assertions of analyze_task_test.py #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vitaliset merged 1 commit into from
Jun 15, 2025
Merged

[Tracing] Refactor assertions of analyze_task_test.py #4828

vitaliset merged 1 commit into from
Jun 15, 2025

Conversation

@vitaliset
Copy link
Collaborator

@vitaliset vitaliset commented Jun 13, 2025 •
edited
Loading

While writing #4827, I realized this pattern might be a better way of asserting the emits (which is pretty similar to what we are doing in events_test.py anyway).

@vitaliset vitaliset requested a review from ViniciustCosta June 13, 2025 14:48
@vitaliset vitaliset merged commit 2b57b36 into master Jun 15, 2025
7 checks passed
@vitaliset vitaliset deleted the rejection_refactor_analyze_test branch June 15, 2025 23:51
vitaliset added a commit that referenced this pull request Jun 30, 2025
@vitaliset
Revert "[Tracing] Refactor assertions of analyze_task_test.py (#4828)"
14d52b5 
This reverts commit 2b57b36.
@vitaliset vitaliset mentioned this pull request Jun 30, 2025
Merged
vitaliset added a commit that referenced this pull request Jun 30, 2025
@vitaliset
MNT Keeping event emissions test standard by mocking `_get_datetime_n…
06536fd 
…ow` (#4850)

Reverts #4828.

Reading #4834 I realized the old approach is simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitorguidi vitorguidi vitorguidi approved these changes

@ViniciustCosta ViniciustCosta Awaiting requested review from ViniciustCosta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vitaliset @vitorguidi