Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update go.yml to build examples #115

Merged
merged 8 commits into from
Dec 5, 2024
Merged

ci: update go.yml to build examples #115

merged 8 commits into from
Dec 5, 2024

Conversation

cuixq
Copy link
Collaborator

@cuixq cuixq commented Dec 3, 2024

This PR updates go.yml to make sure examples can be built successfully.
To address the build failures of two examples, this PR also updates go.mod files.
In addition, this PR lists the directories for building and testing so we don't need to manually list all directories.

@cuixq cuixq marked this pull request as ready for review December 3, 2024 06:41
@cuixq cuixq requested a review from sarnesjo-google December 3, 2024 06:49
run: go test ./...
- name: Run util tests
working-directory: util/
run: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

run: find . -name 'go.mod' -execdir go test \;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to run go test ./... for util/resolve considering there are per-ecosystem tests

@sarnesjo-google sarnesjo-google merged commit 9d051cd into main Dec 5, 2024
2 checks passed
@cuixq cuixq deleted the cuixq-patch-1 branch December 5, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants