util/maven: replace BoolString with TruthyBool and FalsyBool #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuixq
changed the title
sarnesjo-google
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a string field holding boolean value, the default value may be true, and may be false. Currently, we do not specify which type of boolean string, and the client needs to check Maven documentation to decide the actual boolean value.
This PR replaces the existing
BoolStringwithTruthyBool(default value is true) andFalsyBool(default value is false), and implementsBoolean()method for both types so that the clients no need to check the Maven documentation for the default value.Removing
BoolStringis a breaking change, but considering thatutilpackages are not versioned yet, I am not too worried about this.