Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: also return non-zero exit status #122

Merged
merged 8 commits into from
Dec 16, 2024
Merged

ci: also return non-zero exit status #122

merged 8 commits into from
Dec 16, 2024

Conversation

cuixq
Copy link
Collaborator

@cuixq cuixq commented Dec 16, 2024 •
edited
Loading

find -execdir does return non-exit code which hides the build/test failures.

To be able to return non-zero exit code, this PR runs go build and go test in the loop of directories listed by find.

@cuixq cuixq marked this pull request as ready for review December 16, 2024 02:38
@cuixq cuixq changed the title ci: return exist status ci: also return non-zero exist status Dec 16, 2024
@sarnesjo-google sarnesjo-google changed the title ci: also return non-zero exist status ci: also return non-zero exit status Dec 16, 2024
@cuixq cuixq merged commit d1af9d1 into google:main Dec 16, 2024
2 checks passed
@cuixq cuixq deleted the workflow branch December 16, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnesjo-google sarnesjo-google sarnesjo-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuixq @sarnesjo-google